Good vs Bad Feedback
Bad: “This code could be better.” (Vague, not actionable.)
Bad: “Consider refactoring.” (No specific direction.)
Good: “Function processOrder at line 45 is 60 lines long. Extract the validation logic (lines 12–30) into a separate validateOrder function.” (Specific, actionable, located.)
Structured Feedback
The reviewer agent should produce structured feedback with: the file and line number, the issue category (bug, style, architecture, performance), severity (must-fix, should-fix, nice-to-have), and a specific fix suggestion. This format makes it easy for the coding agent to act on and for humans to triage.
Rule of thumb: If a human reviewer wouldn’t understand the feedback, the coding agent won’t either. Review feedback should be as specific as a bug report: what’s wrong, where it is, and how to fix it.